[V0 deprecation] Guided decoding #21347
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes the v0 guided decoding functionality, which simplifies the codebase significantly. The changes mostly consist of deleting old files and removing references to the deprecated v0 guided decoding API, which has been done correctly across the board.
However, I've identified a critical inconsistency regarding the outlines guided decoding backend. While its implementation has been removed, it's still listed as a valid backend in the configuration, leading to contradictory behavior in the tests. My review includes a detailed comment and a suggestion to resolve this ambiguity.
rzabarazesh
force-pushed
the
guided_decoding_deprecation_v0
branch
from
8be0e76 to
6019893
Compare
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
rzabarazesh
force-pushed
the
guided_decoding_deprecation_v0
branch
from
6019893 to
6eaa86b
Compare
rzabarazesh
force-pushed
the
guided_decoding_deprecation_v0
branch
from
6eaa86b to
b594e93
Compare
rzabarazesh
changed the title
rzabarazesh
force-pushed
the
guided_decoding_deprecation_v0
branch
from
b594e93 to
0d62990
Compare
rzabarazesh
requested review from
DarkLight1337,
ywang96,
mgoin,
russellb,
aarnphm,
robertgshaw2-redhat,
simon-mo,
WoosukKwon,
youkaichao,
tlrmchlsmth,
houseroad,
hmellor,
zhuohan123,
alexm-redhat,
comaniac and
njhill
as code owners
Signed-off-by: Harry Mellor <[email protected]>
…e V1 compatible Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]>
rzabarazesh
force-pushed
the
guided_decoding_deprecation_v0
branch
from
ebb4ca5 to
c5e1d9b
Compare
|
@russellb thanks for confirming that |
hmellor
dismissed
their stale review
Originally wasn't sure about some test deletion, it's been confirmed that we can delete them
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
Signed-off-by: Reza Barazesh <[email protected]> Signed-off-by: Harry Mellor <[email protected]> Co-authored-by: Harry Mellor <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Remove v0 guided decoding code.
Test Plan
Test Result
(Optional) Documentation Update