-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
[Core][Feat] Add max-waiting-queue-length parameter to reject requests when waiting queue is full #21352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism to limit the waiting queue size and reject new requests when the queue is full, which is a valuable feature for managing server load. The implementation correctly adds the max-waiting-queue-length
parameter and propagates the SchedulerWaitingQueueFullError
through the system to the API layer.
I've identified a few areas for improvement, mainly related to removing leftover debugging statements and simplifying some validation logic. These changes will help ensure the code is clean and production-ready.
Test
client hey -n 100 -c 10 -m POST \
-H "Content-Type: application/json" \
-H "Authorization: Bearer YOUR_API_KEY" \
-d '{
"messages": [
{"role": "system", "content": "You are a helpful assistant."},
{"role": "user", "content": "Hello! What can you do?"}
],
"temperature": 0.7
}' \
http://localhost:8000/v1/chat/completions vllm log :
|
Hi @robertgshaw2-redhat @chudyandrej PTAL. |
This pull request has merge conflicts that must be resolved before it can be |
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
… waiting queue is full Signed-off-by: chaunceyjiang <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Feature implementation #18826
Test Plan
Test Result
(Optional) Documentation Update