-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Add flashinfer_python
to CUDA wheel requirements
#21389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flashinfer_python
to CUDA wheel requirements
#21389
Conversation
Signed-off-by: mgoin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds flashinfer_python
as a dependency for CUDA environments. While this is useful for local development, it introduces a conflict with the existing Docker build process, which builds FlashInfer from source. This leads to a redundant installation and a version mismatch, making the Docker build fragile and potentially incorrect. I've recommended a solution to conditionally exclude this dependency during the Docker build to resolve the conflict.
flashinfer_python
by default for CUDA requirementsflashinfer_python==0.2.8
by default for CUDA requirements
flashinfer_python==0.2.8
by default for CUDA requirementsflashinfer_python
to CUDA wheel requirements
Signed-off-by: mgoin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Signed-off-by: mgoin <[email protected]>
Purpose
We have installed flashinfer by default in the docker image for a long time, but now as we use flashinfer for many critical kernels for NVIDIA Blackwell we should consider adding it to the default CUDA dependencies.
The
flashinfer-python
wheel by default does not include pre-compiled kernels, so users will JIT at runtime.Test Plan
See if there are any conflicts in CI with the Dockerfile's manual AOT build
Test Result