[Core] Add basic unit test for maybe_evict_cached_block #21400
Conversation
Signed-off-by: Jialin Ouyang <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The test setup for test_maybe_evict_cached_block uses pool.blocks directly, including the null_block which is a special block that should not be cached or be part of the regular block pool logic. The test should only operate on non-null blocks by creating a pool with an extra block and then allocating the test blocks from the free queue. Also, using block.block_id in assertions instead of hardcoding block IDs will make the test more resilient to future changes.
Signed-off-by: Jialin Ouyang <[email protected]>
github-actions
bot
added
the
ready
…#21400) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: qizixi <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: avigny <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: shuw <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: x22x22 <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]>
…#21400) Signed-off-by: Jialin Ouyang <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
#21281 breaks the cache block eviction logic which was fixed by #21357 (Kudos to @simon-mo)
Introduce a unit test to at least cover some basic logic for _maybe_evict_cached_block.
Test Plan
Reject the error to ensure unit test failed.
Test Result
Test failed after locally reverted the fix PR.
(Optional) Documentation Update