Skip to content

[Bugfix] Fix example disagg_example_p2p_nccl_xpyd.sh zombie process #21437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
+1 −0
Merged

[Bugfix] Fix example disagg_example_p2p_nccl_xpyd.sh zombie process #21437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/online_serving/disaggregated_serving_p2p_nccl_xpyd/disagg_example_p2p_nccl_xpyd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ ensure_python_library_installed() {
cleanup() {
echo "Stopping everything…"
trap - INT TERM # prevent re-entrancy
pkill -9 -f "disagg_proxy_p2p_nccl_xpyd.py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using SIGKILL (-9) should be a last resort, as it terminates the process immediately without allowing it to perform any cleanup operations. The disagg_proxy_p2p_nccl_xpyd.py script runs a Quart server, which can handle a graceful shutdown on SIGTERM (the default signal for pkill) to properly close network sockets and other resources.

Forcibly killing the server with SIGKILL might leave resources in an inconsistent state, potentially causing issues like "Address already in use" errors if you run the example again quickly.

I recommend removing the -9 flag to allow the process to shut down gracefully.

Suggested change
pkill -9 -f "disagg_proxy_p2p_nccl_xpyd.py"
pkill -f "disagg_proxy_p2p_nccl_xpyd.py"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kill -- -$$ # negative PID == "this whole process-group"
wait # reap children so we don't leave zombies
exit 0
Expand Down