Skip to content

Conversation

njhill
Copy link
Member

@njhill njhill commented Jul 23, 2025

A huge number of these are logged currently (per worker, per layer)

(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
(DPEngineCoreActor pid=81393) DEBUG 07-23 07:44:18 [config.py:328] Using FusedMoEConfig::max_num_tokens=256
...

A huge number of these are logged currently (per worker, per layer)

Signed-off-by: Nick Hill <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with excessive duplicate debug messages from FusedMoEConfig. The change correctly replaces logger.debug with logger.debug_once, which leverages an LRU cache to ensure the message is logged only once per unique configuration within a worker. This is an effective and clean fix that improves log clarity without introducing any issues. The change is approved.

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) July 23, 2025 12:53
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 23, 2025
@vllm-bot vllm-bot merged commit f0f4de8 into vllm-project:main Jul 24, 2025
79 of 81 checks passed
@njhill njhill deleted the rm-moe-debug-spam branch July 24, 2025 09:24
DW934 pushed a commit to DW934/vllm that referenced this pull request Jul 28, 2025
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
wenscarl pushed a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants