-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Misc] Fix duplicate FusedMoEConfig debug messages #21455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A huge number of these are logged currently (per worker, per layer) Signed-off-by: Nick Hill <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an issue with excessive duplicate debug messages from FusedMoEConfig
. The change correctly replaces logger.debug
with logger.debug_once
, which leverages an LRU cache to ensure the message is logged only once per unique configuration within a worker. This is an effective and clean fix that improves log clarity without introducing any issues. The change is approved.
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: 董巍 <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: avigny <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
A huge number of these are logged currently (per worker, per layer)