-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Deprecation][2/N] Replace --task
with --runner
and --convert
#21470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,111
−1,077
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
719d650
[Frontend] Replace `--task` option with `--runner` and `--convert`
DarkLight1337 9d48e9b
Update
DarkLight1337 e0e1f24
Update
DarkLight1337 aff0874
Remove downstream usages of `model_config.task`
DarkLight1337 e94e121
Merge branch 'main' into rename-task
DarkLight1337 d7ec7ef
Fixes
DarkLight1337 628a9e7
Merge branch 'main' into rename-task
DarkLight1337 2852937
Update docs
DarkLight1337 d6fe44b
Simplify deprecation logic
DarkLight1337 24ca7ba
Fix default runner and conversion
DarkLight1337 4d08cd1
Update
DarkLight1337 7e17f2e
Fix
DarkLight1337 fad33e9
Update docs
DarkLight1337 bbaa245
Fix admonitions
DarkLight1337 7c1dc83
Merge branch 'main' into rename-task
DarkLight1337 52c300b
Improve docs
DarkLight1337 1c6a84e
Merge branch 'main' into rename-task
DarkLight1337 3dfcdb5
Update tests
DarkLight1337 4426f78
Update model resolution
DarkLight1337 b6d41bb
Try fix
DarkLight1337 c764da3
More fixes and cleanup
DarkLight1337 f78fb3d
Make the transformers test stricter
DarkLight1337 0c1266c
Reorder
DarkLight1337 631dfef
Remove local variable that's only used one time
hmellor 2485ebe
Simplify conditions in `_normalize_arch`
hmellor 775aa05
Return `normalized_arch` in `inspect_model_cls`
hmellor 9047c90
Fix verify_and_update_config
DarkLight1337 30d18f2
Merge branch 'main' into rename-task
DarkLight1337 784e723
Update comment
DarkLight1337 330d0ba
Handle `*Model` explicitly
DarkLight1337 b50ac67
Update
DarkLight1337 da0a183
Handle ST models
DarkLight1337 2e66452
Update
DarkLight1337 6e89575
Fix
DarkLight1337 18f0a32
Remove task check
DarkLight1337 f397c91
Merge branch 'main' into rename-task
DarkLight1337 20b8215
Update test
DarkLight1337 b718c8b
Fix model resolution
DarkLight1337 164b05b
Try fix
DarkLight1337 fdcbda0
Always pass model config
DarkLight1337 b1c2118
Fixes
DarkLight1337 1b7e56c
Merge branch 'main' into rename-task
DarkLight1337 b96c651
Merge branch 'main' into rename-task
DarkLight1337 7f438d2
Fix pre-commit
DarkLight1337 397c0c7
Avoid checking imports
DarkLight1337 b3c2535
Fix
DarkLight1337 54b93ba
Try fix
DarkLight1337 803b494
Merge branch 'main' into rename-task
DarkLight1337 6c63bd0
Fix
DarkLight1337 61d5160
Update
DarkLight1337 1ecd6bd
Skip roberta seq cls for V1
DarkLight1337 8925fac
Fix transformers loading
DarkLight1337 cc999d3
Cleanup
DarkLight1337 11377a4
Don't load HF in registry test
DarkLight1337 af6498a
Fix model impl
DarkLight1337 741be47
Fix remaining test
DarkLight1337 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. I think it's unnecessary to set --runner generate in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is unnecessary. I just followed the original code which set the
--task
even though it's unnecessary as wellUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about deleting these unnecessary --runner as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether the original author put them there on purpose, maybe we can address this in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok