Skip to content

Conversation

sarckk
Copy link
Collaborator

@sarckk sarckk commented Jul 23, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Recent Llama4 interleaved RoPE (iRoPE) bug (#21419) shows that we need a unit test to check that iROPE is instantiated correctly for Llama4 family of models.

This PR adds a unit test for this. Once #21324 is merged, this will run in CI.

Test Plan

pytest tests/models/multimodal/generation/test_maverick.py::test_dummy_maverick -s

Test Result

Without #21419:

            assert len(kv_cache_specs.keys()) == num_attention_layers
            for i in range(num_attention_layers):
                if rope_layers[i] == 0:
                    expected_spec = FullAttentionSpec
                else:
                    expected_spec = ChunkedLocalAttentionSpec
E                   AssertionError: assert False
E                    +  where False = isinstance(FullAttentionSpec(block_size=16, num_kv_heads=4, head_size=32, dtype=torch.bfloat16, use_mla=False, sliding_window=None, attention_chunk_size=None), <class 'vllm.v1.kv_cache_interface.ChunkedLocalAttentionSpec'>)

tests/models/multimodal/generation/test_maverick.py:536: AssertionError

With iROPE (#21419) fix, test passes:

2 passed, 6 warnings in 162.68s (0:02:42)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added llama Related to Llama models multi-modality Related to multi-modality (#4194) labels Jul 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a unit test for Llama4 interleaved RoPE, addressing a previous bug. The test creates a reduced model and verifies the KV cache specification. A high-severity suggestion has been made to improve the test's robustness by explicitly setting the VLLM_USE_V1 environment variable.

sarckk added 4 commits July 24, 2025 10:20
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
@sarckk sarckk force-pushed the kv-spec-test-maverick branch from e58eda3 to ccd41de Compare July 24, 2025 17:28
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 25, 2025
@houseroad houseroad enabled auto-merge (squash) July 25, 2025 17:12
@simon-mo simon-mo disabled auto-merge July 26, 2025 00:07
@simon-mo simon-mo merged commit 2eddd43 into vllm-project:main Jul 26, 2025
49 of 51 checks passed
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
HsChen-sys pushed a commit to HsChen-sys/vllm that referenced this pull request Aug 1, 2025
wenscarl pushed a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llama Related to Llama models multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants