-
-
Notifications
You must be signed in to change notification settings - Fork 10k
Add interleaved RoPE test for Llama4 (Maverick) #21478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a unit test for Llama4 interleaved RoPE, addressing a previous bug. The test creates a reduced model and verifies the KV cache specification. A high-severity suggestion has been made to improve the test's robustness by explicitly setting the VLLM_USE_V1
environment variable.
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
e58eda3
to
ccd41de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Recent Llama4 interleaved RoPE (iRoPE) bug (#21419) shows that we need a unit test to check that iROPE is instantiated correctly for Llama4 family of models.
This PR adds a unit test for this. Once #21324 is merged, this will run in CI.
Test Plan
Test Result
Without #21419:
With iROPE (#21419) fix, test passes: