[Do not merge] Debug TPU issues with Xet#21551
[Do not merge] Debug TPU issues with Xet#21551hmellor wants to merge 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Code Review
This pull request appears to be for debugging purposes, adding a RUST_LOG=info environment variable to a test command in the CI script. My review highlights that this change should not be merged into the main branch to avoid verbose CI logs and maintain a clean git history.
| "python3 -m pytest -s -v /workspace/vllm/tests/v1/tpu/test_basic.py" | ||
| run_and_track_test 3 "test_accuracy.py::test_lm_eval_accuracy_v1_engine" \ | ||
| "python3 -m pytest -s -v /workspace/vllm/tests/entrypoints/llm/test_accuracy.py::test_lm_eval_accuracy_v1_engine" | ||
| "RUST_LOG=info python3 -m pytest -s -v /workspace/vllm/tests/entrypoints/llm/test_accuracy.py::test_lm_eval_accuracy_v1_engine" |
There was a problem hiding this comment.
This change introduces a debugging-related environment variable. While the PR title suggests this is not for merging, such changes should not be committed to the main branch. Leaving RUST_LOG=info in the CI script will create excessively verbose logs, which can obscure other important output and make debugging other issues more difficult.
| "RUST_LOG=info python3 -m pytest -s -v /workspace/vllm/tests/entrypoints/llm/test_accuracy.py::test_lm_eval_accuracy_v1_engine" | |
| "python3 -m pytest -s -v /workspace/vllm/tests/entrypoints/llm/test_accuracy.py::test_lm_eval_accuracy_v1_engine" |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
No description provided.