Skip to content

[Bugfix][V1][P/D]Fix the uneven polling issue in the toy proxy for P2pNcclConnector #21819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2025
Merged

[Bugfix][V1][P/D]Fix the uneven polling issue in the toy proxy for P2pNcclConnector #21819

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7de0353
pop->get
Abatom Jul 23, 2025
699ab5f
Merge branch 'main' into xpyd-proxy
Abatom Jul 29, 2025
1b3aa88
bugfix
Abatom Jul 29, 2025
6540884
bugfix
Abatom Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/online_serving/disaggregated_serving_p2p_nccl_xpyd/disagg_proxy_p2p_nccl_xpyd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def _listen_for_register(poller, router_socket):
global prefill_instances
global prefill_cv
with prefill_cv:
node = prefill_instances.pop(data["http_address"], None)
node = prefill_instances.get(data["http_address"], None)
prefill_instances[data["http_address"]] = (
data["zmq_address"],
time.time() + DEFAULT_PING_SECONDS,
Expand All @@ -57,7 +57,7 @@ def _listen_for_register(poller, router_socket):
global decode_instances
global decode_cv
with decode_cv:
node = decode_instances.pop(data["http_address"], None)
node = decode_instances.get(data["http_address"], None)
decode_instances[data["http_address"]] = (
data["zmq_address"],
time.time() + DEFAULT_PING_SECONDS,
Expand Down