[DOC] Fix path of v1 related figures #21868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes broken image paths in several documentation files by updating the asset paths. The changes in the markdown files look good.
However, the PR also includes an unrelated change to examples/offline_inference/basic/basic.py, which updates the example model. To maintain a clean commit history, I've recommended reverting this change and moving it to a separate pull request.
Signed-off-by: Chen Zhang <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
liuyumoye
pushed a commit
to liuyumoye/vllm
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
wenscarl
pushed a commit
to wenscarl/vllm
that referenced
this pull request
Aug 4, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: shuw <[email protected]>
wenscarl
pushed a commit
to wenscarl/vllm
that referenced
this pull request
Aug 4, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: shuw <[email protected]>
vadiklyutiy
pushed a commit
to CentML/vllm
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
x22x22
pushed a commit
to x22x22/vllm
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: x22x22 <[email protected]>
x22x22
pushed a commit
to x22x22/vllm
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: x22x22 <[email protected]>
npanpaliya
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Aug 6, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jinzhen-lin
pushed a commit
to jinzhen-lin/vllm
that referenced
this pull request
Aug 9, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jinzhen Lin <[email protected]>
noamgat
pushed a commit
to noamgat/vllm
that referenced
this pull request
Aug 9, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Noam Gat <[email protected]>
paulpak58
pushed a commit
to paulpak58/vllm
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Paul Pak <[email protected]>
taneem-ibrahim
pushed a commit
to taneem-ibrahim/vllm
that referenced
this pull request
Aug 14, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
BoyuanFeng
pushed a commit
to BoyuanFeng/vllm
that referenced
this pull request
Aug 14, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Boyuan Feng <[email protected]>
diegocastanibm
pushed a commit
to diegocastanibm/vllm
that referenced
this pull request
Aug 15, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Diego-Castan <[email protected]>
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
googlercolin
pushed a commit
to googlercolin/vllm
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Chen Zhang <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
The figures in v1 design docs cannot be rendered after #21832. This PR fix it.
Test Plan
Run CI and see whether the figures can be rendered correctly
Test Result
Let's wait for CI
(Optional) Documentation Update