[Do not Merge] This pr might have triggered a CI bug

[noooop]

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

#21270 Let v1 support encoder-only models, theoretically all pooling models should support v1.

Let's check which models are not supported.

fixed

• fix GteNewModel
• fix JinaRobertaModel
• fix ModernBertModel
• fix NomicBertModel
• float32 is supported by V1
• Alibaba-NLP/gte-Qwen2-1.5B-instruct is supported by V1

address #21470 (comment)

Test Plan

Test Result

(Optional) Documentation Update

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Code Review

This pull request aims to improve v1 engine support for several pooling models. The changes primarily involve removing workarounds and old decorators to align with the v1 architecture. Key changes include:

• Enabling v1 tests for models like gte-Qwen2-1.5B-instruct and gte-modernbert-base by removing test skips.
• Removing the @support_torch_compile decorator from BertModel and ModernBertModel, which is appropriate for the v1 compilation strategy.
• A bug fix in NomicBertModelConfig to correctly calculate rotary_emb_dim as an integer, preventing potential runtime errors.

I've identified a potential issue with the new guard logic in VllmConfig that makes try_verify_and_update_config a one-time execution method. This could prevent re-verification after manual configuration changes, potentially leading to misconfigurations. Please see my detailed comments on this.

[noooop]

@DarkLight1337

Try this PR

What if there are still problems?

QvQ

There must have been a time when it ran successfully.

https://buildkite.com/vllm/ci/builds/25235/steps/canvas?sid=01985436-2932-4921-9e74-ef09dd4f6772

[DarkLight1337]

I suggest to rebase the PR after #21964

[noooop]

@DarkLight1337

#21964 has landed, unblock this pooling tests too