-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[CI/Build] Update causal-conv1d and lm-eval #22141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -535,8 +535,6 @@ steps: | |
- vllm/ | ||
- tests/models/language | ||
commands: | ||
# Install causal-conv1d for plamo2 models here, as it is not compatible with pip-compile. | ||
- pip install 'git+https://github.com/Dao-AILab/[email protected]' | ||
- pip freeze | grep -E 'torch' | ||
- pytest -v -s models/language -m core_model | ||
|
||
|
@@ -547,8 +545,6 @@ steps: | |
- vllm/ | ||
- tests/models/language/generation | ||
commands: | ||
# Install causal-conv1d for plamo2 models here, as it is not compatible with pip-compile. | ||
- pip install 'git+https://github.com/Dao-AILab/[email protected]' | ||
- pytest -v -s models/language/generation -m hybrid_model | ||
|
||
- label: Language Models Test (Extended Generation) # 1hr20min | ||
|
@@ -558,8 +554,6 @@ steps: | |
- vllm/ | ||
- tests/models/language/generation | ||
commands: | ||
# Install causal-conv1d for plamo2 models here, as it is not compatible with pip-compile. | ||
- pip install 'git+https://github.com/Dao-AILab/[email protected]' | ||
- pytest -v -s models/language/generation -m '(not core_model) and (not hybrid_model)' | ||
|
||
- label: Language Models Test (Extended Pooling) # 36min | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,7 +141,7 @@ uv pip install --system \ | |
### causal-conv1d | ||
|
||
```bash | ||
uv pip install 'git+https://github.com/Dao-AILab/[email protected].0.post8' | ||
uv pip install 'git+https://github.com/Dao-AILab/[email protected].2' | ||
``` | ||
|
||
## Update all the different vLLM platforms | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,14 +26,15 @@ torch==2.7.1 | |
torchaudio==2.7.1 | ||
torchvision==0.22.1 | ||
transformers_stream_generator # required for qwen-vl test | ||
causal_conv1d==1.5.2 # required for plamo2 test | ||
mamba_ssm==2.2.5 # required for plamo2 test | ||
matplotlib # required for qwen-vl test | ||
mistral_common[image,audio] >= 1.8.2 # required for voxtral test | ||
num2words # required for smolvlm test | ||
open_clip_torch==2.32.0 # Required for nemotron_vl test | ||
opencv-python-headless >= 4.11.0 # required for video test | ||
datamodel_code_generator # required for minicpm3 test | ||
lm-eval[api]==0.4.8 # required for model evaluation test | ||
lm-eval[api] @ git+https://github.com/EleutherAI/lm-evaluation-harness.git@bc811365ef3917a15da6aac9b7feafb4ba0fb42f # required for model evaluation test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pinning a dependency to a specific commit hash, as done here for |
||
mteb[bm25s]>=1.38.11, <2 # required for mteb test | ||
transformers==4.53.2 | ||
tokenizers==0.21.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning a dependency to a specific commit hash can introduce maintenance and security risks. It makes the build less reproducible if the commit history is changed (e.g., force-push) and bypasses the security vetting of official releases. If this specific commit is necessary to unblock a temporary issue, please add a comment explaining the reason for this pin and which issue/PR it relates to. This will help with future maintenance and make it clear when this can be reverted to a stable, versioned release.