-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[CI] Skip the pooling models that do not support transformers v4.55 #22411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR pins the transformers
library to fix a CI failure. I've suggested adding TODO
comments with references to the tracking issue to ensure the temporary pins and test modifications are reverted when the underlying model incompatibility is resolved.
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: jingyu <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Avery Yingyi Huang <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]>
…llm-project#22411) Signed-off-by: wang.yuqi <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Qwen/Qwen2.5-Math-PRM-7B hf Implementation does not support v4.54.1
refer to #21931 (comment)
Fix #22398
Test Plan
Test Result
(Optional) Documentation Update