Skip to content

Conversation

noooop
Copy link
Contributor

@noooop noooop commented Aug 7, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Qwen/Qwen2.5-Math-PRM-7B hf Implementation does not support v4.54.1

refer to #21931 (comment)

Fix #22398

Test Plan

Test Result

(Optional) Documentation Update

Copy link

github-actions bot commented Aug 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@noooop noooop changed the title [CI] The pooling model is temporarily using transformers 4.53.2 [CI] The pooling model using transformers 4.53.2 temporarily Aug 7, 2025
@mergify mergify bot added the ci/build label Aug 7, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR pins the transformers library to fix a CI failure. I've suggested adding TODO comments with references to the tracking issue to ensure the temporary pins and test modifications are reverted when the underlying model incompatibility is resolved.

@noooop noooop changed the title [CI] The pooling model using transformers 4.53.2 temporarily [CI] Language Models Test (Extended Pooling) using transformers 4.53.2 temporarily Aug 7, 2025
@noooop noooop changed the title [CI] Language Models Test (Extended Pooling) using transformers 4.53.2 temporarily [CI] Skip the pooling models that do not support transformers v4.55 Aug 7, 2025
noooop added 2 commits August 7, 2025 10:06
Signed-off-by: wang.yuqi <[email protected]>
Signed-off-by: wang.yuqi <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 7, 2025 02:24
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 7, 2025
@vllm-bot vllm-bot merged commit 2a4c825 into vllm-project:main Aug 7, 2025
22 of 26 checks passed
nvjullin pushed a commit to nvjullin/vllm that referenced this pull request Aug 7, 2025
jingyu-ml pushed a commit to jingyu-ml/vllm that referenced this pull request Aug 8, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
@noooop noooop deleted the using_4.53 branch August 11, 2025 07:30
yyihuang pushed a commit to yyihuang/vllm that referenced this pull request Aug 11, 2025
aarnphm pushed a commit to aarnphm/vllm that referenced this pull request Aug 13, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 18, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
dumb0002 pushed a commit to dumb0002/vllm that referenced this pull request Aug 28, 2025
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
3 participants