[CI Failure] fix tests/entrypoints/openai/test_skip_tokenizer.py #22708
Conversation
Signed-off-by: wang.yuqi <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix a CI failure for the Prithvi model by changing the default pooling type to All. While this might address the underlying issue related to chunked prefill, it introduces a new problem. The AllPool pooling method only supports the encode task, but the default task for embedding endpoints is embed. This mismatch can lead to incorrect behavior or runtime errors. The change should be revisited to ensure compatibility between the pooling type and supported tasks.
noooop
changed the title
Signed-off-by: wang.yuqi <[email protected]>
noooop
changed the title
DarkLight1337
added
the
ready
|
Would be great you could run |
passed |
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]>
…m-project#22708) Signed-off-by: wang.yuqi <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
address #20930 (comment)
Prithvi should not using chunked prefill & prefix caching
Test Plan
tests/entrypoints/openai/test_skip_tokenizer.py
Test Result
pass
(Optional) Documentation Update