-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Optimize input preparation for FlashInfer [2/N] #23174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant optimizations to the input preparation logic for the FlashInfer attention backend. The key changes include refactoring metadata handling by moving static parameters from FlashInferMetadata
to FlashInferMetadataBuilder
, replacing CPU-intensive PyTorch operations with faster NumPy equivalents, and substituting a slow torch.masked_select
with a custom Triton kernel for preparing paged KV indices. Additionally, the calculation of max_seq_len
is optimized by pre-computing it once. These changes are well-implemented and should lead to noticeable performance improvements. The code quality is high, and the optimizations are sound.
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
@WoosukKwon We found that this optimization can reduce gaps between decoding steps when running with low concurrency. Do you plan to continue working on this so that this can be merged? Thanks! |
Signed-off-by: Michael Goin <[email protected]>
Should be merged after #23147