-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[mypy] Fix incorrect type hint for EAGLE3 support #23617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mypy] Fix incorrect type hint for EAGLE3 support #23617
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix incorrect type hints for EAGLE3 support by changing tuple[int]
to tuple[int, ...]
. While the changes to function signatures are correct, the initialization of self.aux_hidden_state_layers
in LlamaModel
and Qwen2Model
introduces a syntax error that will cause a TypeError
at runtime. I've provided suggestions to fix this critical issue by separating the type hint from the value assignment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: tc-mb <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: tc-mb <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Shiyan Deng <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Purpose
Use
tuple[int, ...]
instead oftuple[int]
. Also see #22080 (comment)Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.