-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[rocm] update pytorch rocm from 6.3 to 6.4 #23968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
draftbk
wants to merge
1
commit into
vllm-project:main
Choose a base branch
from
draftbk:torch-rocm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change correctly points to the PyTorch wheel for ROCm 6.4, it introduces a critical inconsistency with the project's build environment. The base Docker image, defined in
docker/Dockerfile.rocm_base, is still configured to use ROCm 6.3.1 (rocm/dev-ubuntu-22.04:6.3.1-complete).This mismatch between the ROCm version expected by the PyTorch wheel and the version provided by the Docker image will likely lead to build failures or runtime errors. To resolve this, you must also update the
BASE_IMAGEargument indocker/Dockerfile.rocm_baseto a corresponding ROCm 6.4 image.For example:
(Please verify the correct image tag for ROCm 6.4).
Additionally, you should check if other related dependencies in
docker/Dockerfile.rocm_base, such asHIPBLASLT_BRANCHandRCCL_BRANCH, need to be updated for compatibility with ROCm 6.4.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^see this, i think it's a good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile.rocm_base and rocm-build.txt are used in different circumstances.
rocm-build.txt is for bare metal build, without the docker.
When torch is installed from whl, as in the case with rocm-build.txt, blas libraries, and pretty much the entire rocm stack are brought together with this whl, that's why it's so bit, and also why in the normal workflow we don't use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having said that, the ROCm dockerfiles here were out of sync, so I created a parallel PR: #24279
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gshtras Out of curiosity, what is the reason we want to maintain a ROCm version of vLLM? Are there any cool features in ROCm that have not yet been brought to vLLM?
And thanks for the quick review and fix!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ROCm fork is mainly deprecated, when we build our nightly dockers, it's from this upstream repo.
The only thing it's used for is the two dockerfiles, mainly due to our CI constrains (and possibly at least partially because we forgot about it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the information : )