Skip to content

Conversation

@22quinn
Copy link
Collaborator

@22quinn 22quinn commented Oct 27, 2025

Purpose

Increase torchrun / external launcher mode CI coverage to prevent issues like #27502. Reverting #27502 would fail this test.

Test Plan

TP_SIZE=2 DP_SIZE=4 ENABLE_EP=1 torchrun --nproc-per-node=8 examples/offline_inference/torchrun_dp_example.py

Test Result

Pass


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify
Copy link

mergify bot commented Oct 27, 2025

Documentation preview: https://vllm--27548.org.readthedocs.build/en/27548/

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Oct 27, 2025
@22quinn 22quinn added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new CI test for torchrun with 8 GPUs to improve coverage for distributed inference, which is a great addition. The changes in torchrun_dp_example.py to allow configuration via environment variables are necessary for this. I've found a code quality issue in the example script where new module-level variables shadow later assignments, which can be confusing. I've left a couple of suggestions to improve clarity and avoid potential future bugs.

- VLLM_ALLOW_INSECURE_SERIALIZATION=1 RAY_DEDUP_LOGS=0 python3 rlhf_colocate.py
- popd

- label: Distributed Tests (8 GPUs) # ?min
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have the capacity to run this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want to use 8-card capacity, maybe try with H100? example PR https://github.com/vllm-project/vllm/pull/27113/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants