Remove deprecated fields from CompilationConfig
#27593
Open
+52
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harry Mellor <[email protected]>
hmellor
requested review from
LucasWilkinson,
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
|
Documentation preview: https://vllm--27593.org.readthedocs.build/en/27593/ |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated use_cudagraph and full_cuda_graph fields from the CompilationConfig and updates the config tests accordingly. The removal of these flags simplifies the configuration and aligns with the deprecation schedule. The test updates ensure the config tests are passing.
Signed-off-by: Harry Mellor <[email protected]>
fhl2000
approved these changes
Oct 28, 2025
github-actions
bot
added
the
ready
ProExpertProg
approved these changes
Oct 28, 2025
| vllm_config = VllmConfig( | ||
| compilation_config=CompilationConfig( | ||
| mode=CompilationMode.VLLM_COMPILE, | ||
| use_cudagraph=True, |
There was a problem hiding this comment.
Can you make mode explicitly Piecewise here?
| # de-duplicate the sizes provided by the config | ||
| dedup_sizes = list(set(self.compilation_config.cudagraph_capture_sizes)) | ||
| cudagraph_capture_sizes = dedup_sizes | ||
| # filter out sizes larger than max_cudagraph_capture_size |
There was a problem hiding this comment.
Why does this have to be added? Bad merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_cudagraphandfull_cuda_graphhave been deprecated since [Core] Allow full cudagraph with separate attention routines and orthogonal to compilation, add support for FA2 and FlashInfer #20059v0.11.0, which has already been released