[Bug Fix] Re-add the DCP/PCP compatibility check for CUDA platform#34425
[Bug Fix] Re-add the DCP/PCP compatibility check for CUDA platform#34425Siritao wants to merge 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Code Review
This pull request correctly re-adds a critical compatibility check for DCP/PCP with full CUDA graphs on the CUDA platform, which was inadvertently removed. The change prevents crashes by overriding the cudagraph_mode to PIECEWISE when these features are enabled with full CUDA graphs. I've suggested a minor refactoring to improve code maintainability by removing a duplicated line.
Signed-off-by: Siritao <1318342565@qq.com>
|
This pull request has merge conflicts that must be resolved before it can be |
Background:
Note: PR #34179 is adding V2 runner support for DCP with full CUDA graphs. Once merged, this check may become unnecessary, but it's critical for current users.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.