Skip to content

[Bug Fix] Re-add the DCP/PCP compatibility check for CUDA platform#34425

Open
Siritao wants to merge 1 commit intovllm-project:mainfrom
Siritao:dcp-fix
Open

[Bug Fix] Re-add the DCP/PCP compatibility check for CUDA platform#34425
Siritao wants to merge 1 commit intovllm-project:mainfrom
Siritao:dcp-fix

Conversation

@Siritao
Copy link

@Siritao Siritao commented Feb 12, 2026

Background:

Note: PR #34179 is adding V2 runner support for DCP with full CUDA graphs. Once merged, this check may become unnecessary, but it's critical for current users.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added nvidia bug Something isn't working labels Feb 12, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly re-adds a critical compatibility check for DCP/PCP with full CUDA graphs on the CUDA platform, which was inadvertently removed. The change prevents crashes by overriding the cudagraph_mode to PIECEWISE when these features are enabled with full CUDA graphs. I've suggested a minor refactoring to improve code maintainability by removing a duplicated line.

Signed-off-by: Siritao <1318342565@qq.com>
@mergify
Copy link

mergify bot commented Feb 12, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Siritao.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working needs-rebase nvidia

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant