Skip to content

[Bugfix] Delete unused redundant code in Kimi-K2.5#34427

Merged
vllm-bot merged 2 commits intovllm-project:mainfrom
LoganJane:sub_config
Feb 13, 2026
Merged

[Bugfix] Delete unused redundant code in Kimi-K2.5#34427
vllm-bot merged 2 commits intovllm-project:mainfrom
LoganJane:sub_config

Conversation

@LoganJane
Copy link
Contributor

@LoganJane LoganJane commented Feb 12, 2026

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes redundant code from the __init__ method of the KimiK25ForConditionalGeneration class. A deep copy of vllm_config was being created and modified, but the resulting object was unused. The removal of this dead code is a good improvement for code clarity and maintainability. The change is correct and I have no further comments.

@mergify
Copy link

mergify bot commented Feb 12, 2026

Hi @LoganJane, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py Isotr0py enabled auto-merge (squash) February 12, 2026 12:00
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 12, 2026
@LoganJane LoganJane changed the title removing redundant code in kimi-k2.5 [Bugfix] Delete unused redundant code to avoid issues caused by deepcopy Feb 12, 2026
@LoganJane LoganJane changed the title [Bugfix] Delete unused redundant code to avoid issues caused by deepcopy [Bugfix] Delete unused redundant code in Kimi-K2.5 Feb 12, 2026
@mergify mergify bot added the bug Something isn't working label Feb 12, 2026
@vllm-bot vllm-bot merged commit 62788f9 into vllm-project:main Feb 13, 2026
58 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants