Skip to content

[CI/Build] Update video URLs for testing#34446

Merged
vllm-bot merged 2 commits intovllm-project:mainfrom
DarkLight1337:update-video-url
Feb 13, 2026
Merged

[CI/Build] Update video URLs for testing#34446
vllm-bot merged 2 commits intovllm-project:mainfrom
DarkLight1337:update-video-url

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Feb 12, 2026

Purpose

The previous videos used in the test are no longer accessible. Update to use OpenCV samples which are publicly accessible.

cc @khluu can you add these videos to our AWS bucket and open another PR to update the links so we won't run into this issue in the future?

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 12, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the video URLs used in tests, as the previous ones were inaccessible. The new URLs point to OpenCV samples, which is a good improvement. However, one of the new URLs is from a personal blog, which could be unstable and cause test flakiness. I've suggested replacing it with another video from the official OpenCV GitHub repository to improve the reliability of the tests.

@AndreasKaratzas
Copy link
Collaborator

This PR should be good to go once rebased with current main. Issue was resolved by: #34447

@vllm-bot vllm-bot merged commit fc22cae into vllm-project:main Feb 13, 2026
12 of 14 checks passed
@DarkLight1337 DarkLight1337 deleted the update-video-url branch February 13, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants