Skip to content

[CI] Make DBO tests non-optional #34450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucasWilkinson wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −4
Open

[CI] Make DBO tests non-optional #34450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .buildkite/test_areas/distributed.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,16 +138,30 @@ steps:
- TARGET_TEST_SUITE=A100 pytest basic_correctness/ -v -s -m 'distributed(num_gpus=2)'
- pytest -v -s -x lora/test_mixtral.py

- label: Distributed Tests (2 GPUs)(H100)
- label: Distributed MoE Tests (2 GPUs)(H100)
timeout_in_minutes: 15
device: h100
source_file_dependencies:
- vllm/config/parallel.py
- vllm/distributed/
- vllm/model_executor/layers/fused_moe/
- vllm/v1/worker/
- examples/offline_inference/data_parallel.py
- tests/v1/distributed/test_dbo.py
working_dir: "/vllm-workspace/"
num_devices: 2
commands:
- VLLM_USE_DEEP_GEMM=1 VLLM_LOGGING_LEVEL=DEBUG python3 examples/offline_inference/data_parallel.py --model=Qwen/Qwen1.5-MoE-A2.7B -tp=1 -dp=2 --max-model-len=2048 --all2all-backend=deepep_high_throughput
- pytest -v -s tests/v1/distributed/test_dbo.py
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The test_dbo.py test is being promoted to a non-optional CI step because it's effective at catching MoE-related bugs. However, this pytest command is missing the VLLM_USE_DEEP_GEMM=1 environment variable, which is set for the other MoE test command in this same step. This means the DBO test won't cover MoE execution with DeepGEMM kernels, which is a significant gap. To ensure consistent and thorough testing, and to aid in debugging, I recommend adding both VLLM_USE_DEEP_GEMM=1 and VLLM_LOGGING_LEVEL=DEBUG.

  - VLLM_USE_DEEP_GEMM=1 VLLM_LOGGING_LEVEL=DEBUG pytest -v -s tests/v1/distributed/test_dbo.py


- label: Distributed Context Parallel Tests (2 GPUs)(H100)
timeout_in_minutes: 15
device: h100
optional: true
working_dir: "/vllm-workspace/"
num_devices: 2
commands:
- pytest -v -s tests/distributed/test_context_parallel.py
- VLLM_USE_DEEP_GEMM=1 VLLM_LOGGING_LEVEL=DEBUG python3 examples/offline_inference/data_parallel.py --model=Qwen/Qwen1.5-MoE-A2.7B -tp=1 -dp=2 --max-model-len=2048 --all2all-backend=deepep_high_throughput
- pytest -v -s tests/v1/distributed/test_dbo.py
- pytest -v -s tests/distributed/test_context_parallel.py

- label: Distributed Tests (2 GPUs)(B200)
device: b200
Expand Down
Loading