Skip to content

Fix multiline-format string for python 3.10#38739

Merged
hmellor merged 2 commits intovllm-project:mainfrom
neuralmagic:luka/vllm-ir/fix-format-string
Apr 2, 2026
Merged

Fix multiline-format string for python 3.10#38739
hmellor merged 2 commits intovllm-project:mainfrom
neuralmagic:luka/vllm-ir/fix-format-string

Conversation

@ProExpertProg
Copy link
Copy Markdown
Collaborator

@ProExpertProg ProExpertProg commented Apr 1, 2026

Purpose

Fix the format string which is invalid syntax in python 3.10.

Test Plan

CI

Test Result

?


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Luka Govedic <luka.govedic@gmail.com>
@ProExpertProg ProExpertProg added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the construction of the impl_uuids_str variable in vllm/compilation/passes/ir/lowering_pass.py by replacing a nested f-string expression with string concatenation. This change likely improves readability or ensures compatibility with older Python versions. There were no review comments provided, and I have no additional feedback to offer.

Copy link
Copy Markdown
Contributor

@fynnsu fynnsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this fixes the 3.10 syntax issue I saw.

@hmellor hmellor enabled auto-merge (squash) April 1, 2026 17:29
@hmellor hmellor merged commit 6944490 into vllm-project:main Apr 2, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants