Fix ObjectExists method to properly handle wrapped storage.ErrObjectN…#239
Merged
kaovilai merged 1 commit intovmware-tanzu:mainfrom Sep 18, 2025
Merged
Conversation
PrasadJoshi12
force-pushed
the
fix-backup-issue
branch
from
3fb53ae to
9fb6efe
Compare
kaovilai
reviewed
Sep 17, 2025
kaovilai
previously approved these changes
Sep 17, 2025
…otExist errors from Google Cloud Storage API Signed-off-by: Prasad Joshi <prajoshi@redhat.com>
PrasadJoshi12
force-pushed
the
fix-backup-issue
branch
from
9fb6efe to
b231a97
Compare
shubham-pampattiwar
approved these changes
Sep 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 28.39% 28.39%
=======================================
Files 4 4
Lines 574 574
=======================================
Hits 163 163
Misses 399 399
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaovilai
approved these changes
Sep 18, 2025
|
@kaovilai @shubham-pampattiwar cherry-pick to 1.17? |
Collaborator
Already merged on 1.13 (plugin release for 1.17) #240 |
|
Any reason for not making a 1.13.1 release to include this? |
Collaborator
|
vmware-tanzu/velero#9335 (comment) |
|
FYI this is currently NOT in 1.13.0 and breaks all setups using GCP service-accounts for authentication to the GCS buckets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue: #9268