Update neuron.py for save_state warnings on miner #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed call to save_state() which is not implemented
Contributor
Author
waynemystir
reviewed
Feb 17, 2024
Contributor
waynemystir
left a comment
waynemystir
left a comment
There was a problem hiding this comment.
Commenting out self.save_state() doesn't seem like a great option... it would prevent neurons that want to do so from doing so.
|
|
||
| # Always save state. | ||
| self.save_state() | ||
| #self.save_state() |
Contributor
There was a problem hiding this comment.
What happens to neurons that want to save their state?
Contributor
Author
There was a problem hiding this comment.
I dont think they would be missing much:
def save_state(self):
bt.logging.warning(
"save_state() not implemented for this neuron. You can implement this function to save model checkpoints or other useful data."
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commented out call to save_state() which is not implemented