Offer to re-use previously built packages when installing#249
Open
intentionally-left-nil wants to merge 1 commit intovn971:masterfrom
Open
Offer to re-use previously built packages when installing#249intentionally-left-nil wants to merge 1 commit intovn971:masterfrom
intentionally-left-nil wants to merge 1 commit intovn971:masterfrom
Conversation
Author
|
I needed to rebase this a little bit to work with the other PR's I've opened, we can use intentionally-left-nil#5 if the previous PR's are accepted first |
Installing or updating a package causes the package to be rebuilt every time. In the case where multiple packages are installed or updated at once, any singular reason for failure causes all packages to be rebuilt on subsequent install or update commands. This commit detects that a package was already built and verified by the user, and offers to use the previously-built package instead of rebuilding it. In order to prevent out-of-date packages from being used, the commit also ties the package to the git SHA of the build recipe. Any updates or changes will cause the package to be rebuilt. This behavior is presented as a choice to the user. For any package where a cached package is available, the user chooses whether to rebuild it or used the cached version. This choice is per-package. Choosing rebuilding persists the existing behavior, and choosing the cached option skips the build and verify steps of the installation process
0d77b11 to
515463c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing or updating a package causes the package to be rebuilt every time. In the case where multiple packages are installed or updated at once, any singular reason for failure causes all packages to be rebuilt on subsequent install or update commands.
This commit detects that a package was already built and verified by the user, and offers to use the previously-built package instead of rebuilding it.
In order to prevent out-of-date packages from being used, the commit also ties the package to the git SHA of the build recipe. Any updates or changes will cause the package to be rebuilt.
This behavior is presented as a choice to the user. For any package where a cached package is available, the user chooses whether to rebuild it or used the cached version. This choice is per-package. Choosing rebuilding persists the existing behavior, and choosing the cached option skips the build and verify steps of the installation process