Skip to content

Fix missing Docker publish step for R sandbox in workflow#123

Draft
aeeeeeep wants to merge 2 commits into
vndee:mainfrom
aeeeeeep:fix_r_docker
Draft

Fix missing Docker publish step for R sandbox in workflow#123
aeeeeeep wants to merge 2 commits into
vndee:mainfrom
aeeeeeep:fix_r_docker

Conversation

@aeeeeeep

@aeeeeeep aeeeeeep commented Nov 27, 2025

Copy link
Copy Markdown

Summary by CodeRabbit

  • Chores
    • Extended Docker build configuration with an additional container image variant.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: aeeeeeep <aeeeeeep@proton.me>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 27, 2025
@coderabbitai

coderabbitai Bot commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new Docker build matrix entry for dockers/r451.Dockerfile with image tag sandbox-r-451-bullseye is added to the GitHub Actions workflow. All existing entries and workflow steps remain unchanged, extending the set of Docker images built and published.

Changes

Cohort / File(s) Change Summary
GitHub Actions Docker Workflow
\.github/workflows/docker-publish\.yml
Added new matrix entry for dockers/r451.Dockerfile with image sandbox-r-451-bullseye; all existing entries and steps preserved

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single, additive configuration change to YAML
  • No logic, dependency, or step modifications
  • Straightforward pattern extension (adding one matrix entry)

Poem

🐰 A new Docker builds with pride today,
sandbox-r-451 joins the fray!
The matrix grows, workflows run true,
Building images both bright and new! 🐳✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: adding a missing Docker publish step for an R sandbox in the workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added the bug Something isn't working label Nov 27, 2025
@codecov

codecov Bot commented Nov 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.4%. Comparing base (d7ab759) to head (674c44b).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #123   +/-   ##
=====================================
  Coverage   93.4%   93.4%           
=====================================
  Files         31      31           
  Lines       1952    1952           
  Branches     225     225           
=====================================
  Hits        1824    1824           
  Misses        66      66           
  Partials      62      62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vndee

vndee commented Nov 27, 2025

Copy link
Copy Markdown
Owner

Hey @aeeeeeep, I don't know why, but the R image took too long to build, so I decided to disable this CI. I'll manually build and publish this image if needed. Have you tried building it on your local machine? How long does it take now?

@aeeeeeep

Copy link
Copy Markdown
Author

Yes, I built locally and executed the test cases successfully. I noticed that many R libraries needed to be compiled, which made me wait for over 1 hour. I was unable to use the R docker image you released; see #122
I'll see if I can modify the Dockerfile to speed up the compilation. Please wait a moment.

@aeeeeeep aeeeeeep marked this pull request as draft November 27, 2025 11:49
@vndee

vndee commented Nov 27, 2025

Copy link
Copy Markdown
Owner

Yes, I'm not familiar with R, so it would be great if you could help me optimize the Dockerfile.

@aeeeeeep aeeeeeep force-pushed the fix_r_docker branch 3 times, most recently from 1354365 to 1090a26 Compare November 27, 2025 15:37
@sonarqubecloud

Copy link
Copy Markdown

@aeeeeeep

aeeeeeep commented Nov 27, 2025

Copy link
Copy Markdown
Author

@vndee I tried using pak to verify parallel installation locally, but my network environment is too poor.

Failed to update system requirement mappings, will use cached mappings

Could you please help verify the benefits of docker build -t sandbox-r-451-bullseye_speedup -f dockers/r451.Dockerfile .?

@vndee

vndee commented Nov 28, 2025

Copy link
Copy Markdown
Owner

@vndee I tried using pak to verify parallel installation locally, but my network environment is too poor.

Failed to update system requirement mappings, will use cached mappings

Could you please help verify the benefits of docker build -t sandbox-r-451-bullseye_speedup -f dockers/r451.Dockerfile .?

Yes, will do it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants