fix(circomgnark): cache verifying key conversions#393
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements caching for verification key conversions in the circomgnark package to optimize performance when the same verification keys are converted multiple times. The PR moves verification key conversion to occur only when needed (when fixedVk is false) in the ToGnarkRecursion function, and adds two separate caching layers: one for unmarshalling CircomVerificationKey from JSON and another for converting CircomVerificationKey to Gnark format.
Changes:
- Moved verification key conversion in
ToGnarkRecursionfrom unconditional to conditional (only whenfixedVkis false) to avoid unnecessary work - Added caching layer in
UnmarshalCircomVerificationKeyJSONto return the same parsed object for identical JSON input - Added caching layer in
CircomVerificationKey.ToGnark()to return the same converted verification key for the same input object - Introduced comprehensive tests to verify caching behavior and the optimization
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| util/circomgnark/recursion.go | Moved verification key conversion to occur only when fixedVk is false |
| util/circomgnark/conv.go | Added caching to ToGnark() method using pointer-based cache keys |
| util/circomgnark/marshal.go | Added caching to UnmarshalCircomVerificationKeyJSON() using string-based cache keys |
| util/circomgnark/cache_test.go | Added tests to verify caching behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.