don't export vochaininfo metrics during blocksync#1233
Draft
Conversation
Pull Request Test Coverage Report for Build 7447166564
💛 - Coveralls |
altergui
force-pushed
the
feat/no-vochain-metrics-during-sync
branch
from
1dfe271 to
0f17620
Compare
Member
|
Shall we still merge this? @altergui |
altergui
force-pushed
the
feat/no-vochain-metrics-during-sync
branch
from
0f17620 to
89811ab
Compare
Contributor
Author
|
sure, it avoid future noise in grafana |
altergui
force-pushed
the
feat/no-vochain-metrics-during-sync
branch
from
89811ab to
5f2ab6c
Compare
p4u
approved these changes
Jul 1, 2024
altergui
force-pushed
the
feat/no-vochain-metrics-during-sync
branch
from
5f2ab6c to
850aeba
Compare
Contributor
Author
|
for some reason job_compose_test times out. i thought it was something with the CI server but after so many tries it still times out so it looks something related to this PR (even though i don't understand how). will review when i find some time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.