Open
Conversation
export as vue library in prod use bulma package
Author
|
@AlexMordred would you care to take a look at this PR :) |
|
@seriouslag in #132 (comment), Alex says:
So, I think we must follow some checklist, like so:
|
Author
|
Would you care to add more? Are you experiencing any issues when you pull the branch and install deps? I am not seeing any issues on my end. |
|
Just tested it and it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the start of migrating to typescript, exporting type definitions, moving to use vue cli as the bundler for the library, using vue cli as the dev server.
Note dist files will need to be created by a CI pipeline since I removed them from the repo