Add linux sockscan plugin#1120
Conversation
|
Looks like I've not understood how the testing works, it's my own test that's failing. so I'll update that! |
…None' as per CodeQL
digitalisx
left a comment
There was a problem hiding this comment.
Thank you for work @eve-mem
Co-authored-by: Donghyun Kim <digitalisx99@gmail.com>
|
Thanks for merging those changes in directly for me @ikelos, and for the suggested fix @digitalisx. |
…, make use of relative_child_offset, fix f string.
|
Hello @ikelos and @gcmoreira I've tried updating this to work with the various framework changes and updates. You won't have seen this in a little while so I expect you'll have a fair few comments on how I can make this better. Let me know what you think, thanks again for all the help! <3 🦊 |
ikelos
left a comment
There was a problem hiding this comment.
Thanks for being patient with my schedule! It looks like it's there, just a little bit of variable renaming! 5:D
|
Thanks @ikelos |
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
Co-authored-by: ikelos <ikelos@users.noreply.github.com>
…hysical_memory_layer_name for clarity
|
@ikelos I've added those doc strings and used your suggestions for the variable names. Thank you for taking the time to look at this. Sorry for the extra commits when accepting your suggestions, it took me a while to realize it was making a commit for each one 🫤 |
|
Thanks, no problem about the number of changes, I just wanted to make it as easy as possible to apply the changes, lots of commit is no problem if it gets us a mergable result, which it has! 5:D |
|
Thank you @ikelos ! |
Hello 👋
This PR adds a first attempt at a sockscan plugin. Based heavily on the vol2 netscan plugin by @atcuno. I've also added another method following the path from a file object as per the sockstat plugin by @gcmoreira, and to display the results this plugin makes heavy use of the great socket handling from sockstat.
I've tried to include scanning for all the types of sockets supported rather than just the INET ones used un the vol2 plugin. I've hard coded the symbols to search for, I think it has reasonably good coverage of most cases but I'd welcome any feedback.
I've tried adding a test case as well - hopefully I've done that correctly.
Thanks for taking the time to review this, and I look forward to and feedback you might have.
Thank you!
Here is a sample of the results: