remove "daemon" setting, add foreground option#453
remove "daemon" setting, add foreground option#453r00t- merged 4 commits intovolkszaehler:masterfrom
Conversation
|
before that discussion comes up again: |
mbehr1
left a comment
mbehr1
left a comment
There was a problem hiding this comment.
code lgtm and makes perfect sense to remove this flaky feature.
As it's removing existing features aka breaking compatibility I
suggest to e.g. increase major version.
From mailing-list I assume lots of people are using the "one-shot" function (which seem to be somewhat working for some config combinations). So we might expect some "flame-wars" :-)
|
@mbehr1: complaints from (ab)users might be a valid reason to delay this until #450 is done, this also reminds me again that i should provide the details of the brokenness in the commit message. need to look into how to bump the version. |
setting daemon:false was NEVER a useful mode for running vzlogger. it NOT only disabled unix-"daemonization", but it made the reading thread exit after getting a single reading, while it did NOT NOT have vzlogger wait for the logging thread to actually report the data to the api, so data would have been lost most cases. to be replaced with one-shot and foreground options. for now: always run logging thread, always daemonize.
this is intentionally not available via the config-file. partially reverts 1d4972d
r00t-
force-pushed
the
nodaemon_foreground
branch
from
2cee218 to
cdee8b0
Compare
|
updated commit message and some grammar details. |
3 participants
#450 (to also add single-shot mode) is taking a little longer, but propse to merge this to fix #378