Skip to content

mqtt without vzlogger is pointless#576

Open
J-A-U wants to merge 1 commit intovolkszaehler:masterfrom
J-A-U:master
Open

mqtt without vzlogger is pointless#576
J-A-U wants to merge 1 commit intovolkszaehler:masterfrom
J-A-U:master

Conversation

@J-A-U
Copy link
Copy Markdown
Collaborator

@J-A-U J-A-U commented Jan 29, 2023

Optional MQTT is part of vzlogger, therefore compilation of vzlogger by install.sh is necessary. #575

Optional MQTT is part of vzlogger, therefore compilation is necessary.
@r00t-
Copy link
Copy Markdown
Contributor

r00t- commented Jan 30, 2023

this seems a little confused,
at least it took me some reading of the code to understand what the subject/commit-message is trying to say.

could you mention in the commit message that it only affects install.sh?

also, shouldn't vzlogger just be installed unconditionally? i.e. just remove the condition completely?
(as the same thing ("is pointless without vzlogger") could be said about all other libraries that that script can build.)

(personally i don't like this install.sh thing, it seems weird to include such an attempt of package management, and would rather just remove it - but if it's useful to some users, we can keep it ofcourse.)

@J-A-U
Copy link
Copy Markdown
Collaborator Author

J-A-U commented Jan 31, 2023

could you mention in the commit message that it only affects install.sh?

also, shouldn't vzlogger just be installed unconditionally?

I though about that. But don't see a solution that won't break the possibility to do faster updates (without building the libs again).

(personally i don't like this install.sh thing, it seems weird to include such an attempt of package management, and would rather just remove it - but if it's useful to some users, we can keep it ofcourse.)

I'm first row for a better solution and will happily get rid of any mention of install.sh in the wiki if i can replace it with e.g. apt-get.
But only if such a solution is available. A bird in the hand is worth two in the bush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants