Fix Caching#703
Closed
isarrider wants to merge 7 commits intovolkszaehler:masterfrom
Closed
Conversation
Refactor logging statements for improved readability and consistency. Adjust formatting and indentation in various sections of the InfluxDB API implementation.
Added rollback mechanism to restore state on InfluxDB insert failure.
r00t-
reviewed
Apr 23, 2026
| snapshot_lastReadingSent = new Reading(*_lastReadingSent); | ||
| } | ||
|
|
||
| auto rollback_state = [&]() { |
Contributor
There was a problem hiding this comment.
the LLM wasn't allowed to add methods and C++ does not support nested functions,
so it inlines a closure and assigns it to a function pointer variable 😭
LLMs always do this, humans would never...
Contributor
|
thanks... |
Contributor
Author
|
@r00t- thanks for the comment, |
Contributor
Author
|
and I hope you find the time ;) |
Contributor
Author
|
close in favor of #704 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caching didnt work for me so I used Claude to get it fixed...
It seems to work, some help might be needed for the formatting,
I think Github throws an error there...
[edit: intended to fix #702 ]