allow a mnemonic MQTT topic instead of hardcoded chn<number>#706
Open
Zugschlus wants to merge 2 commits intovolkszaehler:masterfrom
Open
allow a mnemonic MQTT topic instead of hardcoded chn<number>#706Zugschlus wants to merge 2 commits intovolkszaehler:masterfrom
Zugschlus wants to merge 2 commits intovolkszaehler:masterfrom
Conversation
This makes it easier to build the source package only, for example for a binary build inside sbuild. Build-Depends: must always be satisfied, Build-Depends-Arch: only when the architecture dependent binary packages are built. So, one just needs debhelper-compat 12, pkgconf, and cmake to build the source package. All the library dev packages are only needed to build the actual binary package. There is also Build-Depends-Indep: for architecture independent packages, but that doesn't apply to vzlogger
Contributor
|
thanks, will have a look |
Contributor
this is #550 :\ |
Contributor
Author
Yes, I agree. This was just annoying enough for me to do this quick fix instead of refactoring the whole thing. |
r00t-
reviewed
Apr 24, 2026
This backwards-compatible change allows one to set the mqtt topic from the channel configurtation. Currently, the meter values are published via an mqtt topic that is set to the channel number, which changes whenever a new channel is defined or and old deleted. And it's totally not mnemonic. This addresses issue volkszaehler#420 from 2020.
Contributor
|
your new push contains the commit from #705 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backwards-compatible change allows one to set the mqtt topic from the channel configuration. Currently, the meter values are published via an mqtt topic that is set to the channel number, which changes whenever a new channel is defined or and old deleted. And it's totally not mnemonic.
Configuration example:
This addresses issue #420 from 2020.