feat: Security hardening, CLI refactoring, and agent metrics#1
Open
foozio wants to merge 4 commits into
Open
Conversation
…hell tools, enhance stream error handling, improve rate limit key extraction, and refine OpenAI message logging.
…hat, and refactor `web_search` and `shell` tools for explicit configuration.
…hance RAG with BM25 ranking, and update README with production security guidelines.
Owner
🔍 Review untuk PR #1 - Security & Architecture CheckTerima kasih atas PR ini, @foozio! Secara keseluruhan ini adalah improvement yang solid. 1️⃣ ZENCLAW_ALLOW_COMMAND_EXEC EnforcementStatus: ✅ Good - tapi need clarification Saya lihat policy ini ditambahkan di Commit b56b5bf. Pertanyaan:
Bisa tunjukkan code snippet enforcement-nya? 2️⃣ Rate Limiting & IP Spoofing RiskStatus: Di let key = headers
.get("x-forwarded-for")
.and_then(|v| v.to_str().ok())
.unwrap_or("unknown")
.to_string(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several requested improvements: