Харитонова Валерия #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 5 alerts when merging b228471 into 383b921 - view on LGTM.com new alerts:
|
vongostev
approved these changes
Oct 28, 2022
Owner
vongostev
left a comment
vongostev
left a comment
There was a problem hiding this comment.
Оба задания принимаю. Учтите на будущее замечания.
| #Задание номер 2 | ||
|
|
||
| with open('test2.txt', 'w+', encoding='utf-8') as f: | ||
| for x in (str(y) for y in range(1, 11)): f.write(x + '\n') |
Owner
There was a problem hiding this comment.
Об этом я уже говорил, если есть двоеточие, должен быть перевод строки.
| #Задание3 | ||
|
|
||
| def average(new_arr): #new_arr заменить на array для тстирования с моментами | ||
| #new_arr = np.moments(array, k) |
Owner
There was a problem hiding this comment.
У Вас очень много ненужных уже комментариев. Перед сдачей лучше их чистить)
| return x | ||
| if lamda < 0: | ||
| raise ValueError | ||
| except ValueError: |
Owner
There was a problem hiding this comment.
Обработку исключений надо проводить так, чтобы под try: catch блок кода был бы минимального размера
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Апгрейд на первое и второе задание.