Skip to content

chore: remove mail rendering#1

Merged
BJTheCod3r merged 2 commits intomainfrom
chore/remove-mail-rendering
Nov 3, 2025
Merged

chore: remove mail rendering#1
BJTheCod3r merged 2 commits intomainfrom
chore/remove-mail-rendering

Conversation

@BJTheCod3r
Copy link
Contributor

This pull request removes the mail rendering abstraction (MailRenderer) from the notifications system. Now, mail messages are sent directly as provided, without a rendering step or renderer injection. The code and documentation are updated to reflect this simplification, and all related interfaces, constants, and tests for mail rendering are removed.

Removal of mail rendering abstraction:

  • The MailRenderer interface and all related code, including the MAIL_RENDERER injection token and mail renderer provider option, are removed.
  • The NodemailerMailAdapter no longer accepts or uses a renderer; it sends the mail message as received. (src/adapters/nodemailer-mail.adapter.ts
  • All tests related to mail rendering are removed from the Nodemailer adapter test suite. (src/__tests__/nodemailer-mail-adapter.spec.ts

API and documentation updates:

  • The toMail method in the notification interface and base class is now explicitly asynchronous, returning a Promise.
  • Documentation is updated to remove references to mail renderers and clarify the simplified mail sending process.

@BJTheCod3r BJTheCod3r self-assigned this Nov 2, 2025
@BJTheCod3r BJTheCod3r changed the title Chore/remove mail rendering chore: remove mail rendering Nov 2, 2025
Copy link
Contributor

@tobycodes tobycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BJTheCod3r BJTheCod3r merged commit a4fcfa9 into main Nov 3, 2025
1 check passed
@BJTheCod3r BJTheCod3r deleted the chore/remove-mail-rendering branch November 6, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants