Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the mail rendering abstraction (
MailRenderer) from the notifications system. Now, mail messages are sent directly as provided, without a rendering step or renderer injection. The code and documentation are updated to reflect this simplification, and all related interfaces, constants, and tests for mail rendering are removed.Removal of mail rendering abstraction:
MailRendererinterface and all related code, including theMAIL_RENDERERinjection token and mail renderer provider option, are removed.NodemailerMailAdapterno longer accepts or uses a renderer; it sends the mail message as received. (src/adapters/nodemailer-mail.adapter.tssrc/__tests__/nodemailer-mail-adapter.spec.tsAPI and documentation updates:
toMailmethod in the notification interface and base class is now explicitly asynchronous, returning aPromise.