-
Notifications
You must be signed in to change notification settings - Fork 715
Allow for multiple Lighter instances #6555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6c4273a
rm ghost looker for 2D, make lighter atom configurable
benjaminpkane e34b877
hide incompatible modal action when annotating
benjaminpkane d18f814
Merge branch 'develop' into cleaning/lighter
benjaminpkane ef2ea66
make lighter canvases reusable
benjaminpkane af1aa05
cleanup
benjaminpkane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
app/packages/core/src/components/Modal/Lighter/ReusableCanvas.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /** | ||
| * Copyright 2017-2025, Voxel51, Inc. | ||
| */ | ||
|
|
||
| /** | ||
| * A reusable canvas manager that creates and maintains a persistent canvas | ||
| * element. | ||
| * | ||
| * A ReusableCanvas and a SharedPixiApplication allows a single WebGL context | ||
| * to be maintained across Lighter scenes. | ||
| */ | ||
| class ReusabledCanvas { | ||
| private canvas: HTMLCanvasElement; | ||
|
|
||
| constructor(id = "default") { | ||
| this.canvas = document.createElement("canvas"); | ||
| this.canvas.id = `lighter-canvas-${id}`; | ||
| this.canvas.setAttribute("data-cy", `lighter-sample-renderer-canvas-${id}`); | ||
| this.canvas.style.display = "block"; | ||
benjaminpkane marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| this.canvas.style.flex = "1"; | ||
| } | ||
|
|
||
| /** | ||
| * Get the canvas | ||
| * | ||
| * If a container is provided, the canvas will be attached to it. | ||
| */ | ||
| getCanvas(container: null | HTMLElement) { | ||
| if (!container || container === this.canvas.parentNode) { | ||
| return this.canvas; | ||
| } | ||
|
|
||
| this.canvas.remove(); | ||
| container.appendChild(this.canvas); | ||
|
|
||
| return this.canvas; | ||
| } | ||
benjaminpkane marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** | ||
| * Detach the canvas from its current container. | ||
| * The canvas element itself is preserved for reuse. | ||
| */ | ||
| detach() { | ||
| if (this.isCanvasAttached()) { | ||
| this.canvas.remove(); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Get the current canvas element without attaching to a container. | ||
| */ | ||
| getCanvasElement() { | ||
| return this.canvas; | ||
| } | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** | ||
| * Check if the canvas is currently attached to a container. | ||
| */ | ||
| isCanvasAttached() { | ||
| return !!this.canvas.parentNode; | ||
| } | ||
| } | ||
|
|
||
| export default ReusabledCanvas; | ||
|
|
||
| export const defaultCanvas = new ReusabledCanvas(); | ||
91 changes: 0 additions & 91 deletions
91
app/packages/core/src/components/Modal/Lighter/SharedCanvas.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.