Skip to content

Remove dependency to mcollective module #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove dependency to mcollective module #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30bac66
Remove dependency to the choria/mcollective module
h-haaks Jul 18, 2025
c62c81e
Remove unused git fixture
h-haaks Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .fixtures.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ fixtures:
choria: https://github.com/choria-io/puppet-choria.git
concat: https://github.com/puppetlabs/puppetlabs-concat.git
cron_core: https://github.com/puppetlabs/puppetlabs-cron_core.git
git: https://github.com/puppetlabs/puppetlabs-git.git
Copy link
Member

@bastelfreak bastelfreak Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the other mcollective entries as well?

Copy link
Contributor Author

@h-haaks h-haaks Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried that but then all the test failed ...
Had to put them back one by one to get all the tests green :)

inifile: https://github.com/puppetlabs/puppetlabs-inifile.git
mcollective: https://github.com/choria-io/puppet-mcollective.git
stdlib: https://github.com/puppetlabs/puppetlabs-stdlib.git
Expand Down
3 changes: 2 additions & 1 deletion REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ Default value: `[]`

Data type: `Boolean`


Install the r10k mcollective agent
Requires the choria/mcollective module to be installed

Default value: `$r10k::params::mcollective`

Expand Down
2 changes: 2 additions & 0 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# @param gentoo_keywords
# @param install_options
# @param mcollective
# Install the r10k mcollective agent
# Requires the choria/mcollective module to be installed
# @param git_settings
# @param deploy_settings
# @param root_user
Expand Down
4 changes: 0 additions & 4 deletions metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"author": "Vox Pupuli",
"license": "Apache-2.0",
Expand Down Expand Up @@ -83,10 +83,6 @@
"name": "puppetlabs/vcsrepo",
"version_requirement": ">= 1.3.1 < 8.0.0"
},
{
"name": "choria/mcollective",
"version_requirement": ">= 0.10.0 <1.0.0"
},
{
"name": "puppet/systemd",
"version_requirement": ">= 3.2.0 < 9.0.0"
Expand Down