Fill test gaps: devices loader, get_all_data, dashboard smoke test#2
Merged
Fill test gaps: devices loader, get_all_data, dashboard smoke test#2
Conversation
- tests/test_devices.py: covers load_driver happy path, YAML default fallbacks, CLI override, and unknown device error (14 new tests). - tests/test_base_driver.py: adds TestGetAllData covering band splitting by X_TP_Band, index fallback for single-band routers, client SSID enrichment, unknown-iface fallback, and empty-state behaviour. - tests/test_dashboard.py: smoke test that instantiates WifiDashboard with a fake driver and runs compose() to catch import/reactive-binding regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for previously untested parts of the codebase. No runtime code changes.
load_driverhappy path, YAML default fallbacks for both host and username, CLI override, and unknown-device error. Catches the bug fixed in PR Post-review fixes: username bug, CI, platform marker, README polish #1 (username default short-circuit).TestGetAllDatacovering band splitting byX_TP_Band, index fallback for single-band routers, client SSID enrichment, unknown-iface fallback, and empty-state behaviour.WifiDashboardwith a fake driver and runscompose()to catch import/reactive-binding regressions.fake_driverfixture that stubs out the fiveBaseDriverabstract methods, replacing three copy-pastedFakeDriverclasses across the test suite.Test plan
uv run pytest -v— 41/41 passing locally (27 existing + 14 new)uvx ruff check .— clean