Score channels by RSSI and adjacent-channel overlap#4
Merged
Conversation
Previously recommend_channel used raw network counts, which treated one strong nearby network the same as five weak ones and ignored 2.4 GHz adjacent-channel interference. Now: - score_channels() weights each nearby network by RSSI bucket (strong > −55 dBm gets 3.0, medium −55..−75 gets 1.5, weak < −75 gets 0.5). - On 2.4 GHz, a network on channel N spills into ±1..±4 with decreasing weight (1.0, 0.5, 0.5, 0.25, 0.25). 5 GHz channels at 20 MHz don't overlap so no spill is applied there. - recommend_channel picks the lowest-scoring channel (same current-channel tiebreaker as before). Raw counts are still used for the dashboard chart. Added 4 new tests covering strong-vs-weak weighting, 2.4 GHz spill, 5 GHz no-overlap, and empty input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously `recommend_channel` used raw network counts — treated one strong nearby AP the same as five weak ones and ignored 2.4 GHz adjacent-channel interference.
Now the recommender weights each nearby network by signal strength and, on 2.4 GHz, by distance from the candidate channel.
Test plan