This repository was archived by the owner on Mar 18, 2021. It is now read-only.
Implementation of str.upper and cleaning code #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| code_point = args[0] | ||
| return 0 <= code_point <= 0x10ffff | ||
| # args[0] => code_point | ||
| return 0 <= args[0] <= 0x10ffff |
Owner
There was a problem hiding this comment.
I don't understand the purpose of this change. It makes the code less readable. The fact that you added a comment means that the code is unclear. I consider that if the code is clear enough, it doesn't require a comment.
Your commit message says "Elimination of unused variables", but it's wrong: the variable is used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.