fix: storybook build process #3114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ommeirelles
requested review from
lariciamota and
lemagnetic
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
eduardoformiga
left a comment
eduardoformiga
left a comment
There was a problem hiding this comment.
Lots of files changed, and I had a lot of questions hahah
- faststore/cli command to calculate graphql chaced queries You can test it by running the cli on the starter or on the core mannualy. Ex: - Running on core ``` $ pnpm i $ cd ./packages/core $ (../cli & pnpm build) $ node ../cli/bin/run generate-types $ node ../cli/bin/run cache-graphql ``` Builds the cli, and regenerated the types to create the persisted-documents.json file and run the cache-graphql. After running it you should see the discovery.config.default.js changed to include all the queries names that would be cached. --------- Co-authored-by: Fanny Chien <[email protected]>
lemagnetic
approved these changes
Dec 2, 2025
Contributor
lemagnetic
left a comment
lemagnetic
left a comment
There was a problem hiding this comment.
LGTM! Builds and tests passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.