fix(theme): fix getSidebar's buggy logic when supporting subtree-lift… #4842
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(theme): fix getSidebar's buggy logic when supporting subtree-lift…
close #4841
Description
This PR resolves when sidebar config object owns a uplifting subtree node (by duplication),
getSidebar
will match the obviously wrong dir links, for example described in issue #4841,/api-examples.md
will be matched to/a
.Not only when there is subtree lifting will the bug reproduce, and I'm also afraid when doing matching of
/api-b/a.md
, it will be matched to/api/
, and I also proved this guess, the sidebar object is, can also see my repo's newest commit:And my PR also fixed this problem.
Linked Issues
fixes #4841
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publish
below.