Skip to content

Accodions now use native details/summary #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsdev
Copy link

@jsdev jsdev commented Jul 17, 2025

  • clickHandler not needed
  • icon button not needed, kept icon as is and styles as is,
  • just NOW much better SCREEN READER support and easier to maintain since native
Screenshot 2025-07-16 at 9 55 14 PM

🎯 Final State:
✅ All files properly formatted with prettier
✅ No syntax errors in HTML files
✅ Clean CSS rules without duplicates
✅ Client builds successfully
✅ Correct caret rotation: 90° when closed, 0° when open

Description

Linked Issues

Additional Context


Tip

The author of this PR can publish a preview release by commenting /publish below.

…n button not needed, kept icon as is and styles as is, just not better SCREEN READER support and easier to maintain since native

🎯 Final State:
✅ All files properly formatted with prettier
✅ No syntax errors in HTML files
✅ Clean CSS rules without duplicates
✅ Client builds successfully
✅ Correct caret rotation: 90° when closed, 0° when open
@jsdev
Copy link
Author

jsdev commented Jul 17, 2025

addresses: #4846

@veloz-web
Copy link

this PR addresses: 3804
4846 was closed as duplicate of: 3804

@olets
Copy link
Contributor

olets commented Jul 17, 2025

@veloz-web
Copy link

@olets
yes looks like we saw and solved the same issue.

your branch needs to resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants