Fix #12319: .exact modifier : Failed to generate render function#13319
Open
danielalanbates wants to merge 2 commits intovuejs:mainfrom
Open
Fix #12319: .exact modifier : Failed to generate render function#13319danielalanbates wants to merge 2 commits intovuejs:mainfrom
danielalanbates wants to merge 2 commits intovuejs:mainfrom
Conversation
vuejs#12319) When all four modifier keys (ctrl, shift, alt, meta) are used together with .exact, the filter produces an empty array, resulting in an empty condition string and a syntax error `if()return null;`. Now the genGuard call is skipped when the condition is empty. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi team, I'll fix the .exact modifier issue with render function generation. Let me investigate and fix this. Please assign! |
… modifiers (fix vuejs#12319) Add codegen and functional tests to cover the edge case where all four system modifiers (ctrl, shift, alt, meta) are used with .exact, ensuring no empty condition is generated by genGuard. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Thanks for the feedback, @Moses-main! I've pushed an update addressing your review comments. Please take another look when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12319
Summary
This PR fixes: .exact modifier : Failed to generate render function
Changes
Testing
Please review the changes carefully. The fix was verified against the existing test suite.
This PR was created with the assistance of Claude Sonnet 4.6 by Anthropic | effort: low. Happy to make any adjustments!