HTML Validation - Grid Results View#4881
Open
crhallberg wants to merge 4 commits intovufind-org:dev-12.0from
Open
HTML Validation - Grid Results View#4881crhallberg wants to merge 4 commits intovufind-org:dev-12.0from
crhallberg wants to merge 4 commits intovufind-org:dev-12.0from
Conversation
Member
|
Thanks, @crhallberg. Since this is a significant restructuring of templates, I have put this on the 12.0 milestone, since we didn't get it done in time for 11.0. Since there are no HTML validation test failures in the current test suite, I'm curious how you caught this. Do we need to add a new Mink test that enables checkboxes and grid view at the same time, to prevent future regressions? I haven't had a chance to do hands-on testing of this one yet; maybe @sturkel89 can help with that when time permits! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts grid view templates to remove the label within a label issue. Took the opportunity to improve the checkboxes and use CSS grid.